boards/jiminy-mega256rfr2: remove mentions in applications and board/common#12399
Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom Oct 8, 2019
Merged
Conversation
fjmolinas
added
CI: ready for build
Remove the deprecated board from BOARD_BLACKLIST and BOARD_INSUFFICIENT_MEMORY.
The board is deprecated, no need to ignore this board anymore here. Having the `arduino` and `periph_pwm` features is now required for all boards using 'arduino-atmega' (as it was except for that board). If this should change in the future, it should be defined either in each arduino board, in another board common, or per CPU_MODEL.
aabadie
force-pushed
the
pr/board/jiminy-mega256rfr2/correctly_cleanup
branch
from
8da5bd7 to
ec93d4c
Compare
Contributor
Author
|
Thank you for the review and fixing the conflicts. I noticed yesterday evening the conflicts in the BOARD_BLACKLIST and INSUFFICIENT_MEMORY but did not have time to do it directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The board was removed in #12182 but specific handling or definitions were still referenced in the repository.
Remove the deprecated board from BOARD_BLACKLIST and BOARD_INSUFFICIENT_MEMORY in applications.
Remove special case for jiminy-mega256rfr2 in boards/common/arduino-atmega
Having the
arduinoandperiph_pwmfeatures is now required for allboards using 'arduino-atmega' (as it was except for that board).
If this should change in the future, it should be defined either in each
arduino board, in another board common, or per CPU_MODEL.
Testing procedure
The board is now not referenced anymore except in release-notes and lost and found.
Issues/PRs references
Found while rebasing the cleanup to not do per board blacklisting of features.
Board was removed in "boards: Remove support for the Jiminy-Mega256RFR2" #12182