gnrc_netif: avoid deprecated as source addresses, don't prefer them!#12405
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Oct 9, 2019
Merged
Conversation
miri64
added
Type: bug
aabadie
added
the
CI: ready for build
Contributor
I'll do some basic testing, please don't merge yet. |
Member
Author
|
@kaspar030 did you? |
Member
|
@kaspar030, this PR is for the release, and freeze is scheduled for tomorrow. Please make this a priority if at all possible. |
Contributor
Yes, I tested basic networking, still works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While digging for the reasons of the checks removed in #12404 I found another bug in the source selection algorithm.
Testing procedure
Should be clear with some logical thinking ;-)
Issues/PRs references
Found while digging for #12404.