boards/microduino-corerf: Initial support by benpicco · Pull Request #12411 · RIOT-OS/RIOT

benpicco · 2019-10-09T22:43:47Z

Contribution description

The Microduino CoreRF is an inexpensive breakout board for the ATmega128RFA1 MCU.

The ATmega128RFA1 is the predecessor of the ATmega256RFR2. The ATmega256/128/64RFR2 data sheet says

Backward compatibility of the ATmega256/128/64RFR2 to the ATmega128RFA1 is
provided in most cases. However some incompatibilities may exist.
The ATmega256/128/64RFR2 uses the same package as the ATmega128RFA1.

Further search in the data sheet shows that the incompatibilities only concern different ADC characteristics.

Testing procedure

The board itself is rather spartan. It only provides a reset button and a non-controllable power LED.

The RX/TX pins have to be connected to a user-provided serial adapter to provide a UART interface.

Flashing

The board comes pre-flashed with an Arduino compatible bootloader, but I managed to delete it.
I've then spent way too much time trying to re-flash it (especially since most instructions call for a special capacitor on the reset line) until I discovered that flashing works remarkably well with a FT232H USB dongle I happened to have - no extra components needed.

All guides on how to re-flash the Arduino bootloader recommend using the Arduino IDE - which does not seem to support the FT232H dongle.

Since it works well with plain avrdude I decided not to bother with the bootloader and instead enjoy the additional ROM space.

If required, I can see how I can restore the bootloader and flash using that.

Tests

Since the board is basically just a plain Atmega MCU, I just checked if stdio and timers work.

For this I flashed examples/default, tests/xtimer_msg and tests/xtimer_drift - they all behaved as expected.

I did not test the radio yet.

Issues/PRs references

#9172 will add support for the radio

maribu

Code-wise this looks fine to me. Just ordered two boards so that I can test. I guess this has to wait until the end of the soft feature freeze anyway, so hopefully the boards arrive soon and testing will not add additional delay.

boards/common/atmega/board.c

boards/microduino-corerf/doc.txt

cpu/atmega128rfa1/include/atmega_pcint.h

cpu/atmega128rfa1/ldscripts_compat/avr_2.26.ld

boards/microduino-corerf/doc.txt

maribu

Works as expected :-) Let me check that moving the CPU-ID to atmega_common does not have any unexpected side affects on the other ATmegas. Then I'll ACK

maribu · 2019-10-15T12:43:06Z

OK, the Arduino-Mega2560 still works fine. The test in tests/periph_cpuid works as expected on the microduino

boards/microduino-corerf/Makefile.include

maribu

ACK

benpicco · 2019-10-15T12:50:36Z

I'll still need to update some BOARD_INSUFFICIENT_MEMORY lists. But some test builds will fail already because of #12412 😉

benpicco · 2019-10-15T16:27:01Z

I added the board to the BOARD_INSUFFICIENT_MEMORY lists. That revealed some more issues in Murdock for which I had to provide more !fixups.

Are you fine with those? Than I'll squash again.

maribu · 2019-10-16T08:30:50Z

Yes. please squash again. I'd like to test one final time before merging.

(@maribu: Note to myself: Add boards/common/atmega/Makefile.features to reduce code duplication.)

Both atmega128rfa1 and atmega256rfr2 implement it.

GPIO_UNDEF is already defined in periph_cpu_common.h, so the redefinition is never used.

This prevents a conflict with an unrelated Atmel header file.

The SLEEP define collides with an Atmel header file. Rename the define to resolve the conflict.

benpicco · 2019-10-17T17:32:10Z

Rebased now that #12484 is merged.
#12485 eased the pain: I added the Makefile.ci target and then ran for i in *; do make -C $i Makefile.ci; done

This would generate fresh Makefile.cis based on the content of the old Makefile. find . -name Makefile.ci -size 37c -delete then helped to get rid of the empty ones.

Merging the Makefile.cis was then much easier than going through everything by hand again.

maribu

ACK. Feel free to hit the merge button in order to reduce the chance of a new merge conflict popping up.

maribu · 2019-10-17T19:19:47Z

The very second I wrote this, Murdock passed 🤣

benpicco · 2019-10-17T19:21:10Z

Thank you for the review!
And it sounds like you even bought one of those devices yourself 😃

maribu · 2019-10-17T19:34:10Z

Two. I figured I sooner or later someone should test the driver for the 802.15.4 transceiver, and that will be more fun with two devices. (Even though I also have other boards with radios that should be compatible over the air.)

aabadie · 2019-10-17T19:56:30Z

It seems 2 unrelated commits went through: d92e2b2 and 252f22b. They are harmless, so not a big deal, but we should be careful that it doesn't happen too often.

maribu · 2019-10-17T20:13:43Z

They were needed to resolve name conflicts

maribu · 2019-10-17T20:19:58Z

The commit messages also document this. So the commit were required to resolve compilation issues, relevant for this PR (as they resolve compilation issues), reasonable (only internal defines are changes and the bew names make sense) and properly documented (the commit messages are right to the point).

aabadie · 2019-10-18T06:01:47Z

Indeed, I missed the detailed part of the commit messages. At first sight, this was surprising.

benpicco added Platform: AVR Platform: This PR/issue effects AVR-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Oct 9, 2019

benpicco mentioned this pull request Oct 9, 2019

Jiminy Support for at86rfr2 transceiver #9172

Closed

benpicco force-pushed the atmega128rfa1 branch from 684edeb to f3a411c Compare October 9, 2019 22:52

benpicco mentioned this pull request Oct 9, 2019

tests: replace SLEEP define #12412

Merged

benpicco requested a review from maribu October 9, 2019 23:47

maribu reviewed Oct 10, 2019

View reviewed changes

boards/common/atmega/board.c Show resolved Hide resolved

boards/microduino-corerf/doc.txt Outdated Show resolved Hide resolved

cpu/atmega128rfa1/include/atmega_pcint.h Show resolved Hide resolved

cpu/atmega128rfa1/ldscripts_compat/avr_2.26.ld Show resolved Hide resolved

benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 10, 2019

benpicco force-pushed the atmega128rfa1 branch from 6d13814 to 59fbf0e Compare October 10, 2019 09:28

maribu reviewed Oct 15, 2019

View reviewed changes

boards/microduino-corerf/doc.txt Show resolved Hide resolved

maribu added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Oct 15, 2019

maribu reviewed Oct 15, 2019

View reviewed changes

benpicco force-pushed the atmega128rfa1 branch from 6b6e0ad to 4763fce Compare October 15, 2019 12:37

maribu reviewed Oct 15, 2019

View reviewed changes

boards/microduino-corerf/Makefile.include Outdated Show resolved Hide resolved

maribu approved these changes Oct 15, 2019

View reviewed changes

benpicco force-pushed the atmega128rfa1 branch from 4763fce to 28fc0c2 Compare October 15, 2019 13:59

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 15, 2019

benpicco force-pushed the atmega128rfa1 branch from c62af55 to df5978d Compare October 16, 2019 09:56

benpicco mentioned this pull request Oct 17, 2019

tests: Moved BOARD_INSUFFICIENT_MEMORY to Makefile.ci #12484

Merged

cpu/atmega_common: provide dummy implementation for led_init()

6617c5c

benpicco and others added 6 commits October 17, 2019 19:20

cpu/atmega128rfa1: ATmega128rfa1 MCU support

7d78e32

cpu/atmega_common: move periph/cpuid.c to common code

b1ef68a

Both atmega128rfa1 and atmega256rfr2 implement it.

cpu/atmega256rfr2: small cleanup

6cf6dcb

GPIO_UNDEF is already defined in periph_cpu_common.h, so the redefinition is never used.

drivers/nrf24l01p: rename CMD_NOP -> CMD_NOOP

d92e2b2

This prevents a conflict with an unrelated Atmel header file.

tests/driver_hih6130: replace SLEEP define

252f22b

The SLEEP define collides with an Atmel header file. Rename the define to resolve the conflict.

boards/microduino-corerf: Initial board support

2090632

benpicco force-pushed the atmega128rfa1 branch from df5978d to e245fd3 Compare October 17, 2019 17:25

benpicco force-pushed the atmega128rfa1 branch 2 times, most recently from f4e8fea to a5bf856 Compare October 17, 2019 17:48

benpicco added 2 commits October 17, 2019 20:38

examples: add microduino-corerf to Makefile.ci

936da68

tests: add microduino-corerf to Makefile.ci

c01eae3

benpicco force-pushed the atmega128rfa1 branch from a5bf856 to c01eae3 Compare October 17, 2019 18:38

maribu approved these changes Oct 17, 2019

View reviewed changes

maribu merged commit cf81dff into RIOT-OS:master Oct 17, 2019

benpicco deleted the atmega128rfa1 branch October 17, 2019 19:19

aabadie mentioned this pull request Oct 18, 2019

cpu/atmega: cleanup dependencies handling #12489

Merged

fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019

leandrolanzieri mentioned this pull request Dec 8, 2020

tests: remove unused driver_mpu9150 directory #15587

Merged

Conversation

benpicco commented Oct 9, 2019

Contribution description

Testing procedure

Flashing

Tests

Issues/PRs references

Uh oh!

maribu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maribu left a comment

Choose a reason for hiding this comment

Uh oh!

maribu commented Oct 15, 2019

Uh oh!

Uh oh!

maribu left a comment

Choose a reason for hiding this comment

Uh oh!

benpicco commented Oct 15, 2019

Uh oh!

benpicco commented Oct 15, 2019

Uh oh!

maribu commented Oct 16, 2019

Uh oh!

benpicco commented Oct 17, 2019

Uh oh!

maribu left a comment

Choose a reason for hiding this comment

Uh oh!

maribu commented Oct 17, 2019

Uh oh!

benpicco commented Oct 17, 2019

Uh oh!

maribu commented Oct 17, 2019

Uh oh!

aabadie commented Oct 17, 2019

Uh oh!

maribu commented Oct 17, 2019

Uh oh!

maribu commented Oct 17, 2019

Uh oh!

aabadie commented Oct 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants