Skip to content

MAINTAINING.md: Added doc on release process#12500

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
maribu:maintainer-doc
May 14, 2020
Merged

MAINTAINING.md: Added doc on release process#12500
miri64 merged 1 commit intoRIOT-OS:masterfrom
maribu:maintainer-doc

Conversation

@maribu
Copy link
Member

@maribu maribu commented Oct 18, 2019

Contribution description

Added informations relevant to maintainers on how the normal review process differs during the feature freeze, or when the are targeting a release rather than the master branch.

Testing procedure

Doesn't apply

Issues/PRs references

#12486

@maribu maribu added the Area: doc Area: Documentation label Oct 18, 2019
@maribu maribu requested a review from a team October 18, 2019 15:44
@miri64 miri64 removed their assignment Oct 18, 2019
@miri64 miri64 added Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) labels Oct 18, 2019
@miri64
Copy link
Member

miri64 commented Oct 18, 2019

Don't want it to be appear that I'm the only one responsible for this update to the maintainer guidelines, so I removed the assignment to me.

@maribu
Copy link
Member Author

maribu commented Oct 19, 2019

I think a follow up PR would be reasonable to also document other special handling during review, as:

  • Changes in core need two ACKs
  • API changes need two ACKs
    • Deprecation process is needed on API changes if the API was included in a release so far
  • ...

But I guess it is better to keep this PR focused.

@miri64
Copy link
Member

miri64 commented Oct 19, 2019

  • API changes need two ACKs

    • Deprecation process is needed on API changes if the API was included in a release so far

I think we should also discuss this. I heard this now a few times by different people, but I can't remember that we ever decided on that. [edit]Also what exactly an API change is should be ironed out[/edit]

@fjmolinas
Copy link
Contributor

I think we pretty much agree on this one right @miri64 @maribu? IMO this is ok to squash.

Added informations relevant to maintainers on how the normal review process
differs during the feature freeze, or when the are targeting a release rather
than the master branch.
@maribu
Copy link
Member Author

maribu commented Jan 15, 2020

Squashed

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 15, 2020
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@aabadie
Copy link
Contributor

aabadie commented May 14, 2020

The 2 required ACKs are there on this one. @miri64 @fjmolinas do they still hold ?

@miri64
Copy link
Member

miri64 commented May 14, 2020

Our release process did not change, so yes!

@miri64 miri64 merged commit 477b29c into RIOT-OS:master May 14, 2020
@maribu maribu deleted the maintainer-doc branch May 14, 2020 20:08
@maribu
Copy link
Member Author

maribu commented May 14, 2020

Thanks for the reviews :-)

@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants