boards/atmega256rfr2-xpro: initial support#12639
Conversation
f6ad8c7 to
a4d4d4d
Compare
87dc5cf to
21ba47c
Compare
|
I went a little further here:
This PR is no longer a draft. |
21ba47c to
66f28d7
Compare
benpicco
left a comment
There was a problem hiding this comment.
Looks pretty straightforward, good to hear debugging works!
|
Thanks for reviewing @benpicco. If you don't mind, before merging, I'd like to provide more test results with this board. |
|
I tested a bit the radio with |
|
Failing automatic tests: I'm looking into them. |
boards/atmega256rfr2-xpro: initial support
|
Too bad, you merged this on a little bit too early: the failing tests revealed a misconfiguration of the clock on that board. Indeed, it provides an external 16MHz oscillator that can be enabled by properly enabling the low fuse byte. I was just testing with this and it's fixing a lot of timeout issues in the tests. Will provide this in a follow-up PR. |
|
BTW what is @riot-ci exactly ? who is behind this ? |
|
Oh! I had this page open on my phone and never intended to merge it. I guess it unlocked in my pocket. Sorry! |
|
Btw: The debugger included in this board cannot by chance be connected to other external ATmega boards? |
It's the account Murdock uses to access GitHub, so our CI team (@kaspar030, @smlng, ...) |
|
I think I have access as well, somehow. |
|
Why are you asking? |
This message appeared in the PR yesterday: Not sure what this is about. |
|
Given these two PRs RIOT-OS/RobotFW-tests#20, RIOT-OS/RobotFW-tests#21, I guess @smlng was logged in as the wrong user again ;-). |
|
I'm wondering however if and why @riot-ci needs push rights to master. |
|
wasn't me, at least I wasn't using the riot-ci user lately (and also shouldn't anyway, other than by mistake). However, that commit or push was not done by me. |
Something can be soldered on the back of the board but that doesn't seem very easy. Of course there's nothing in their user guide about that. |
|
OK, I see. Thanks for the info! |
Contribution description
This PR is adding an initial support for the ATmega256RFR2 Xplained pro board.
Interesting things with this board:
I ran the compile_and_test_for_board.py script and it reports several problems. I'll have a look at that later.
The PR is marked as a draft until the board is fully tested/configured.
Testing procedure
Issues/PRs references
Based on #12608 to avoid having to update BLACKLIST_BOARD variables that will be removed anyway once merged.