pkg/ubasic: use features blacklist and remove use of BOARD_BLACKLIST in test#12643
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Nov 5, 2019
Merged
Conversation
AVR8, MSP430, RISV and MIPS are excluded because of missing features in their respective toolchains
The corresponding arch features are blacklisted at package level
aabadie
added
Area: tests
miri64
approved these changes
Nov 5, 2019
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Murdock still passes and only the ESP8266 boards you pointed out in OP are added to info-boards-supported
--- /dev/fd/63 2019-11-05 09:18:32.777079510 +0100
+++ /dev/fd/62 2019-11-05 09:18:32.781079590 +0100
@@ -24,6 +24,8 @@
esp32-wemos-lolin-d32-pro
esp32-wroom-32
esp32-wrover-kit
+esp8266-esp-12x
+esp8266-olimex-mod
esp8266-sparkfun-thing
f4vi1
feather-m0(interestingly there was already an esp8266 not blacklisted)
Let's go ahead with this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR blacklist unsupported architectures for the ubasic package at the package level. This way there's no need to define the BOARD_BLACKLIST variable in the corresponding test.
This PR is follow-up of #12608.
The list of boards supported is the nearly the same compared to master. Apparently the reason for blacklisting the esp8266 architecture is no longer true. It builds just fine now.
This PR
master
diff
Testing procedure
make -C tests/pkg_ubasic info-boards-supportedis changed, but with good reasons.Issues/PRs references
Follow-up of #12608