Skip to content

pkg/oonf_api: add avr8 and msp430 arch to features blacklist#12644

Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/oonf_api_features_blacklist
Nov 5, 2019
Merged

pkg/oonf_api: add avr8 and msp430 arch to features blacklist#12644
aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/oonf_api_features_blacklist

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 5, 2019

Contribution description

This allows to drop the BOARD_BLACKLIST in the tests/nhdp application because nhdp module depends on the oonf_api package.

Testing procedure

  • a green Murdock
  • make -C tests/nhdp info-boards-supported should return the same list of boards

Issues/PRs references

Follow-up of #12608

AVR8 and MSP430 are excluded because of missing features in their respective toolchains
The corresponding arch features are blacklisted in oonf_api package which is a dependency of nhdp
@aabadie aabadie added Area: tests Area: tests and testing framework Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 5, 2019
@aabadie aabadie requested a review from miri64 November 5, 2019 08:47
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Output of make -C tests/nhdp/ --no-print-directory info-boards-supported is identical

$ git checkout master && make -C tests/nhdp/ --no-print-directory info-boards-supported | sha1sum
Already on 'master'
Your branch is up to date with 'upstream/master'.
35fbb308a14d125da98db9ce020056d71e0d3389  -
$ git pr upstream 12644 && make -C tests/nhdp/ --no-print-directory info-boards-supported | sha1sum
From git://github.com/RIOT-OS/RIOT
 * branch                  refs/pull/12644/head -> FETCH_HEAD
Note: checking out 'FETCH_HEAD'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at bf1b6b6f9c tests/nhdp: remove useless BOARD_BLACKLIST
35fbb308a14d125da98db9ce020056d71e0d3389  -

@miri64
Copy link
Member

miri64 commented Nov 5, 2019

Just hit the green button, when Murdock is happy :-)

@aabadie aabadie merged commit c210658 into RIOT-OS:master Nov 5, 2019
@aabadie aabadie deleted the pr/pkg/oonf_api_features_blacklist branch November 5, 2019 09:08
@aabadie
Copy link
Contributor Author

aabadie commented Nov 5, 2019

Thanks for reviewing @miri64 :)

@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants