pkg/oonf_api: add avr8 and msp430 arch to features blacklist#12644
Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom Nov 5, 2019
Merged
pkg/oonf_api: add avr8 and msp430 arch to features blacklist#12644aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie merged 2 commits intoRIOT-OS:masterfrom
Conversation
AVR8 and MSP430 are excluded because of missing features in their respective toolchains
The corresponding arch features are blacklisted in oonf_api package which is a dependency of nhdp
miri64
approved these changes
Nov 5, 2019
Member
miri64
left a comment
There was a problem hiding this comment.
ACK. Output of make -C tests/nhdp/ --no-print-directory info-boards-supported is identical
$ git checkout master && make -C tests/nhdp/ --no-print-directory info-boards-supported | sha1sum
Already on 'master'
Your branch is up to date with 'upstream/master'.
35fbb308a14d125da98db9ce020056d71e0d3389 -
$ git pr upstream 12644 && make -C tests/nhdp/ --no-print-directory info-boards-supported | sha1sum
From git://github.com/RIOT-OS/RIOT
* branch refs/pull/12644/head -> FETCH_HEAD
Note: checking out 'FETCH_HEAD'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b <new-branch-name>
HEAD is now at bf1b6b6f9c tests/nhdp: remove useless BOARD_BLACKLIST
35fbb308a14d125da98db9ce020056d71e0d3389 -
Member
|
Just hit the green button, when Murdock is happy :-) |
Contributor
Author
|
Thanks for reviewing @miri64 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This allows to drop the BOARD_BLACKLIST in the tests/nhdp application because nhdp module depends on the oonf_api package.
Testing procedure
make -C tests/nhdp info-boards-supportedshould return the same list of boardsIssues/PRs references
Follow-up of #12608