Skip to content

pkg/semtech-loramac: blacklist arch_msp430 and remove use of BOARD_BLACKLIST#12718

Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/semtech-loramac_blacklist_arch
Nov 15, 2019
Merged

pkg/semtech-loramac: blacklist arch_msp430 and remove use of BOARD_BLACKLIST#12718
aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/semtech-loramac_blacklist_arch

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 15, 2019

Contribution description

This PR blacklist the MSP430 architecture in the semtech-loramac package dependencies and as a result, removes the need of BOARD_BLACKLIST in the corresponding test application.
Note that pic32-clicker/wifire boards were also in this list but are not concerned by the change in the package: this is because they are not providing 2 required feartures (spi/gpio_irq) and thus don't need to be explicitly blacklisted.

Testing procedure

  • A green Murdock
  • Compare the list of supported boards between this PR and master: there should be no unexpected difference:

Using

$ make --no-print-directory -C tests/pkg_semtech-loramac info-boards-supported
this PR 
acd52832 airfy-beacon arduino-due arduino-duemilanove arduino-leonardo arduino-mega2560 arduino-mkr1000 arduino-mkrfox1200 arduino-mkrwan1300 arduino-mkrzero arduino-nano arduino-uno arduino-zero atmega256rfr2-xpro atmega328p avsextrem b-l072z-lrwan1 b-l475e-iot01a blackpill blackpill-128kib bluepill bluepill-128kib cc2538dk ek-lm4f120xl esp32-mh-et-live-minikit esp32-olimex-evb esp32-wemos-lolin-d32-pro esp32-wroom-32 esp32-wrover-kit esp8266-esp-12x esp8266-olimex-mod esp8266-sparkfun-thing feather-m0 firefly fox frdm-k22f frdm-k64f frdm-kw41z hamilton i-nucleo-lrwan1 ikea-tradfri iotlab-a8-m3 iotlab-m3 limifrog-v1 lobaro-lorabox lsn50 maple-mini mega-xplained microduino-corerf msba2 msbiot mulle nrf51dk nrf52840-mdk nrf52840dk nrf52dk nrf6310 nucleo-f031k6 nucleo-f042k6 nucleo-f072rb nucleo-f091rc nucleo-f103rb nucleo-f207zg nucleo-f302r8 nucleo-f303k8 nucleo-f303re nucleo-f303ze nucleo-f334r8 nucleo-f401re nucleo-f410rb nucleo-f411re nucleo-f412zg nucleo-f413zh nucleo-f429zi nucleo-f446re nucleo-f446ze nucleo-f767zi nucleo-l031k6 nucleo-l053r8 nucleo-l073rz nucleo-l152re nucleo-l432kc nucleo-l433rc nucleo-l452re nucleo-l476rg nucleo-l496zg nucleo-l4r5zi nz32-sc151 openmote-b openmote-cc2538 p-l496g-cell02 particle-argon particle-boron particle-xenon pba-d-01-kw2x phynode-kw41z pyboard reel remote-pa remote-reva remote-revb ruuvitag samd21-xpro same54-xpro saml10-xpro saml11-xpro saml21-xpro samr21-xpro samr30-xpro samr34-xpro sensebox_samd21 slstk3401a slstk3402a sltb001a slwstk6000b-slwrb4150a slwstk6000b-slwrb4162a sodaq-autonomo sodaq-explorer sodaq-one sodaq-sara-aff spark-core stk3600 stk3700 stm32f030f4-demo stm32f0discovery stm32f3discovery stm32f429i-disc1 stm32f4discovery stm32f723e-disco stm32l0538-disco ublox-c030-u201 udoo usb-kw41z waspmote-pro yunjia-nrf51822
master 
acd52832 airfy-beacon arduino-due arduino-duemilanove arduino-leonardo arduino-mega2560 arduino-mkr1000 arduino-mkrfox1200 arduino-mkrwan1300 arduino-mkrzero arduino-nano arduino-uno arduino-zero atmega256rfr2-xpro atmega328p avsextrem b-l072z-lrwan1 b-l475e-iot01a blackpill blackpill-128kib bluepill bluepill-128kib cc2538dk ek-lm4f120xl esp32-mh-et-live-minikit esp32-olimex-evb esp32-wemos-lolin-d32-pro esp32-wroom-32 esp32-wrover-kit esp8266-esp-12x esp8266-olimex-mod esp8266-sparkfun-thing feather-m0 firefly fox frdm-k22f frdm-k64f frdm-kw41z hamilton i-nucleo-lrwan1 ikea-tradfri iotlab-a8-m3 iotlab-m3 limifrog-v1 lobaro-lorabox lsn50 maple-mini mega-xplained microduino-corerf msba2 msbiot mulle nrf51dk nrf52840-mdk nrf52840dk nrf52dk nrf6310 nucleo-f031k6 nucleo-f042k6 nucleo-f072rb nucleo-f091rc nucleo-f103rb nucleo-f207zg nucleo-f302r8 nucleo-f303k8 nucleo-f303re nucleo-f303ze nucleo-f334r8 nucleo-f401re nucleo-f410rb nucleo-f411re nucleo-f412zg nucleo-f413zh nucleo-f429zi nucleo-f446re nucleo-f446ze nucleo-f767zi nucleo-l031k6 nucleo-l053r8 nucleo-l073rz nucleo-l152re nucleo-l432kc nucleo-l433rc nucleo-l452re nucleo-l476rg nucleo-l496zg nucleo-l4r5zi nz32-sc151 openmote-b openmote-cc2538 p-l496g-cell02 particle-argon particle-boron particle-xenon pba-d-01-kw2x phynode-kw41z pyboard reel remote-pa remote-reva remote-revb ruuvitag samd21-xpro same54-xpro saml10-xpro saml11-xpro saml21-xpro samr21-xpro samr30-xpro samr34-xpro sensebox_samd21 slstk3401a slstk3402a sltb001a slwstk6000b-slwrb4150a slwstk6000b-slwrb4162a sodaq-autonomo sodaq-explorer sodaq-one sodaq-sara-aff spark-core stk3600 stk3700 stm32f030f4-demo stm32f0discovery stm32f3discovery stm32f429i-disc1 stm32f4discovery stm32f723e-disco stm32l0538-disco ublox-c030-u201 udoo usb-kw41z waspmote-pro yunjia-nrf51822
diff

Issues/PRs references

Follow-up of #12608

@aabadie
pkg/semtech-loramac: blacklist MSP430 based boards
5400ab7 
EXIT_SUCCESS/EXIT_FAILURE macros are not provided by the toolchain, which ends-up in a failing build
@aabadie
tests/pkg_semtech-loramac: remove useless BOARD_BLACKLIST
c3a647f 
msp430 architecture is blacklisted at package level. pic32-clicker/wifire boards doesn't provided the some required features (SPI, GPIO_IRQ)
@aabadie aabadie added Area: tests Area: tests and testing framework Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Nov 15, 2019
@aabadie aabadie requested a review from fjmolinas November 15, 2019 17:32
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 15, 2019
benpicco
benpicco approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward. Always good to have less of those lists.

@aabadie aabadie merged commit 9fa6a8c into RIOT-OS:master Nov 15, 2019
@aabadie aabadie deleted the pr/pkg/semtech-loramac_blacklist_arch branch November 15, 2019 18:09
@aabadie
Copy link
Contributor Author

aabadie commented Nov 15, 2019

Thanks @benpicco !

@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

No one assigned

Labels

Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

3 participants

@aabadie @benpicco @fjmolinas