tools/serial.inc.mk: add support miniterm.py#12743
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Nov 19, 2019
Merged
Conversation
miniterm.py is a simple terminal program that is included with pyserial. This means that it is available wherever pyterm can work. It allows raw access, does line translation and passes through special characters. Co-authored-by: Juan Carrano <j.carrano@fu-berlin.de>
aabadie
added
Type: new feature
1 task
kaspar030
reviewed
Nov 19, 2019
| TERMFLAGS ?= --nolock --imap lfcrlf --baud "$(BAUD)" "$(PORT)" | ||
| else ifeq ($(RIOT_TERMINAL),miniterm) | ||
| TERMPROG ?= miniterm.py | ||
| # The RIOT shell will still transmit back a CRLF, but at least with --eol LF |
Contributor
There was a problem hiding this comment.
The RIOT shell will still transmit back a CRLF
really?
Contributor
There was a problem hiding this comment.
I don't understand neither the issue nor the comment. RIOT should send LF on every "\n", which the terminal is supposed to turn into "\r\n" before sending to the console, so "--eol LF" is definitely correct.
Contributor
Author
There was a problem hiding this comment.
I don't understand neither the issue nor the comment.
This is taken as-is from the original PR. Do you have a better suggestion for the comment ?
Contributor
There was a problem hiding this comment.
Ah, what's happening is that miniterm sends "\r\n" on enter, and the RIOT shell accepts both as newline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miniterm.py is a simple terminal program that is included with pyserial.
This means that it is available wherever pyterm can work. It allows raw
access, does line translation and passes through special characters.
Co-authored-by: Juan Carrano j.carrano@fu-berlin.de
Contribution description
This PR adds support for miniterm as alternative for
RIOT_TERMINAL.It's a rework of the initial PR: #11003
Testing procedure
The following should launch miniterm instead of pyterm:
Issues/PRs references
Will be useful for #2968