cpu/esp32: fix of thread priorities levels#12753
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Nov 21, 2019
Merged
Conversation
gschorcht
added
Area: cpu
aabadie
reviewed
Nov 20, 2019
aabadie
reviewed
Nov 20, 2019
aabadie
reviewed
Nov 20, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
I confirm that the mentioned tests are failing on master (except xtimer_mutex...) and are fixed by this PR.
Please address the minor change requests and this PR is good to go. You can squash directly.
A number of tests insist that the number of thread priority levels is 16. However, when using the WiFi interface, a number of high priority threads are required to handle the WiFi hardware. In this case, the number of thread priority levels must be 32. Solves the problem of tests `tests/shell`.
gschorcht
force-pushed
the
cpu/esp32/fix_sched_prio
branch
from
0f2acdf to
7b1ef78
Compare
Contributor
Author
|
@aabadie Many thanks for the quick review. I'm really surprised how fast the process can be 😄 |
17 tasks
Contributor
From my experience, this is the combination of several factors:
|
Contributor
Author
|
@aabadie Thanks again for reviewing, testing and merging. BTW, I have now a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If the WiFi interface is enabled with module
esp_wifioresp_now, a number of high priority threads are created to handle the WiFi hardware events. In this case, the number of thread priority levels has to be 32. However, a number of tests insist that the number of thread priority levels is 16.This PR introduces the conditional setting of
SCHED_PRIO_LEVELSto satisfy number of tests:tests/cond_ordertests/mutex_ordertests/rmutex_cpptests/rmutextests/posix_semaphoretests/shelltests/xtimer_mutex_lock_timeoutThis PR belongs to the series of PRs, each with very small changes that fix automatic tests on ESP32 boards.
Testing procedure
Make, flash and execute one of the tests mentioned above, for example,
Issues/PRs references
Requires #12752