cpu/esp32: fix heap command output#12754
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Nov 20, 2019
Merged
Conversation
The heap command output has to have an output format that is compatible with the test.
gschorcht
added
Area: cpu
aabadie
approved these changes
Nov 20, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
ACK
Output is now consistent with other architectures. Calling heap shell command in tests/heap_cmd returns the following:
esp32-wroom-32
2019-11-20 21:53:04,980 # heap
2019-11-20 21:53:04,983 # heap: 185288 (used 876, free 184412) [bytes]
atmega256rfr2-xpro
2019-11-20 21:55:22,171 # heap
2019-11-20 21:55:22,174 # heap: 30548 (used 0, free 30548) [bytes]
And the test is passing on atmega256rfr2-xpro.
Contributor
Author
|
Thanks for testing. |
Contributor
Author
|
BTW, I have an open issue #12173 which will separate the output of heap statistics from gathering the heap statistics. This will avoid such inconsistencies between platforms in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the output of the heap command. The has to have an output format that is compatible with the test. With this PR,
tests/heap_cmdworks for ESP32 boards.This PR belongs to the series of PRs, each with very small changes that fix automatic tests on ESP32 boards.
Testing procedure
Make, flash and execute
tests/heap.Issues/PRs references
Requires #12752