cpu/esp32: fix xtimer dependency#12757
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Nov 21, 2019
Merged
Conversation
gschorcht
added
Area: cpu
aabadie
reviewed
Nov 20, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
I confirm this is fixing tests/periph_timer on esp32 but it introduces other problems with the CI. See below.
gschorcht
force-pushed
the
cpu/esp32/fix_xtimer_deps
branch
from
d647e26 to
ad8bdcf
Compare
Removes the dependency of the module riot_freertos from module xtimer. This avoids that xtimer is used even if it is not really needed which in turn occupies the first timer device and tests/periph_timer fails.
gschorcht
force-pushed
the
cpu/esp32/fix_xtimer_deps
branch
from
ad8bdcf to
9a17420
Compare
17 tasks
aabadie
approved these changes
Nov 21, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
CI is green now.
ACK and go!
Contributor
Author
|
Thanks for reviewing, testing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Removes the dependency of the
riot_freertosmodule from modulextimer. This avoids thatxtimeris used even if it is not really needed which in turn occupies the first timer device sotests/periph_timerfails.Fixes the automatic test output of
tests/periph_timersfor ESP32.This PR belongs to the series of PRs, each with very small changes that fix automatic tests on ESP32 boards.
Testing procedure
Make, flash and test `tests/periph_timer.
Issues/PRs references
Requires #12752