sys/crypto: Use FEATURE_REQUIRED += arch_32bit instead of manual blacklists#12762
Closed
maribu wants to merge 2 commits intoRIOT-OS:masterfrom
Closed
sys/crypto: Use FEATURE_REQUIRED += arch_32bit instead of manual blacklists#12762maribu wants to merge 2 commits intoRIOT-OS:masterfrom
FEATURE_REQUIRED += arch_32bit instead of manual blacklists#12762maribu wants to merge 2 commits intoRIOT-OS:masterfrom
Conversation
The code in sys/crypto is currently not portable to non-32 bit systems. By requiring the features arch_32bit, some headaches can be avoided.
As sys/crypto now requires arch_32bit, no manual blacklists are required anymore.
maribu
added
Area: build system
Contributor
|
Personally, I prefer #12645 ;) |
Member
Author
Yep. Fixing the issue is definitely better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
FEATURE_REQUIRED += arch_32bittosys/cryptoTesting procedure
Run
make -C tests/sys_crypto info-boards-supportedwith master and this PR. Thediffshould be empty.Issues/PRs references
None