Skip to content

CONTRIBUTING.md: hint to also search closed PRs for previous work#12770

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:also_search_closed_prs_before_contributing
Nov 21, 2019
Merged

CONTRIBUTING.md: hint to also search closed PRs for previous work#12770
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:also_search_closed_prs_before_contributing

Conversation

@kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Nov 21, 2019

Contribution description

Hint to also search closed PRs when looking for previous work before contributing.

Testing procedure

Issues/PRs references

E.g., #12740 was opened without considering a previous closed PR. Author claims to have searched only for open ones (as that's the default).

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 21, 2019
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Makes sense and is straight-forward.

@kaspar030 kaspar030 merged commit af9f105 into RIOT-OS:master Nov 21, 2019
@kaspar030 kaspar030 deleted the also_search_closed_prs_before_contributing branch November 21, 2019 14:52
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants