cpu/common/esp8266: use 'awk/printf' instead of 'echo'#12850
Merged
gschorcht merged 1 commit intoRIOT-OS:masterfrom Dec 1, 2019
Merged
cpu/common/esp8266: use 'awk/printf' instead of 'echo'#12850gschorcht merged 1 commit intoRIOT-OS:masterfrom
gschorcht merged 1 commit intoRIOT-OS:masterfrom
Conversation
bergzand
added
CI: ready for build
gschorcht
reviewed
Dec 1, 2019
Contributor
gschorcht
left a comment
gschorcht
left a comment
There was a problem hiding this comment.
Many echo implementations are not compliant with the Unix specification which doesn't allow option processing for the echo command. Therefore, the echo command is considered to be non-portable command and the printf command is prefered. Thus, this change makes sense.
gschorcht
added
Area: build system
Contributor
|
@LordTy Thanks for figuring out the problem and providing the fix. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a fix for the same issue encountered with the esp32 in #12244
With the new esp toolchain from #11108, this breaks on OSX.
So this changes the uses of "echo -n" to printf, in the same way as #12282
Testing procedure
Same as #12282
Issues/PRs references
Fixes issue #12244 for the esp8266