boards/microduino-corerf: small fixups#12874
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Dec 4, 2019
Merged
Conversation
The MCU can handle that baud rate just fine. A standard baud rate is much easier to use than those awkward 57600 baud.
The board *does* have a crystal oscillator connected, so we can enable RTT.
benpicco
added
Type: enhancement
Contributor
Contributor
Author
|
Ah I thought that was only used during Deep Sleep and sourced from the CPU clock in normal operation. |
Contributor
My understanding as well... You'll need the 32KHz xtal to source when in set_sleep_mode(SLEEP_MODE_PWR_SAVE) and |
maribu
approved these changes
Dec 4, 2019
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
ACK. Makes sense code-wise and you provided the test results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When doing the
microduino-corerfport I was somehow beset by the cargo-cultish idea that ATmega couldn't do 115200 baud UART.This is of course bogus and using half of 115200 for no good reason is just odd.
Now the board uses 115200 baud like everyone else and when attaching a serial terminal one no longer has to wonder what the proper baud rate was.
I also thought that the board was so bare-bones, it had no external oscillator, so I couldn't enable the RTT.
#12852 should also work on boards without oscillator, so I wanted to try that out. It worked, but upon closer inspection I found the oscillator and noticed the RTT was already working on
master.Testing procedure
flash
tests/periph_rtt.You will see that RTT and the UART output at 115200 baud works.
Issues/PRs references
none