cpu/esp*: fixes for tests/pkg_spiffs and tests/pkg_littlefs#12890
Merged
kaspar030 merged 2 commits intoRIOT-OS:masterfrom Dec 6, 2019
Merged
cpu/esp*: fixes for tests/pkg_spiffs and tests/pkg_littlefs#12890kaspar030 merged 2 commits intoRIOT-OS:masterfrom
kaspar030 merged 2 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
added
Area: cpu
ESP32 nodes can crash during SPI Flash write operations if required parts of the code are not in the IRAM but in the cached SPI Flash memory, which is disabled during the SPI Flash write operations. Therefore, the code of the SPIFFS package and the VFS module are now stored in the IRAM.
To avoid that murdock times out before tests/pkg_spiffs and tests/pkg_littlefs time out, the configured test timeouts for these tests is reduced to 200 seconds which should be enough. An ESP32 needs an average of 60 seconds for these tests, while an ESP8266 needs in average 100 seconds.
gschorcht
force-pushed
the
cpu/esp/fix_tests_spiffs
branch
from
033fa12 to
35357b8
Compare
kaspar030
approved these changes
Dec 6, 2019
Contributor
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
ACK. I confirm this fixes the test on esp32-wroom-32.
I find it extremely unfortunate that the esp linker scripts have any module and even pkg specific code in them...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the problem with
tests/pkg_spiffsthat occurred in #11449 after merging PR #12810.SPI flash write operations require to disable the cache for the program code in SPI flash memory. Therefore, the program code required during SPI flash write operations has to be placed in IRAM. With this PR, the code of
pkg_spiffsandvfsis therefore placed in IRAM by the linker script.Furthermore, this PR reduces the configured test timeout for
tests/pkg_spiffsandtests/pkg_littlefsto avoid that murdock times out before these tests time out. The configured timeout is now 200 seconds which should be enough. An ESP32 needs an average of 60 seconds for these tests, while an ESP8266 needs in average 100 seconds.Testing procedure
Flash and test
tests/pkg_spiffswith and without this PR.The test should crash or timeout without this PR and should work as expected with the PR.
Issues/PRs references
Solves the problem with
tests/pkg_spiffsin #11449.