netdev_ieee802154: return PDU based on PHY mode#12937
Closed
benpicco wants to merge 2 commits intoRIOT-OS:masterfrom
Closed
netdev_ieee802154: return PDU based on PHY mode#12937benpicco wants to merge 2 commits intoRIOT-OS:masterfrom
benpicco wants to merge 2 commits intoRIOT-OS:masterfrom
Conversation
This adds PHY modes for IEEE 802.15.4-2003 and IEEE 802.15.4g-2012.
benpicco
added
Area: network
miri64
reviewed
Dec 12, 2019
miri64
reviewed
Dec 12, 2019
IEEE 802.15.4g-2012 specifies a PDU of 2047 for it's PHY modes, so query the driver for the mode before returning the PDU.
benpicco
force-pushed
the
ieee802154g_pdu
branch
from
d83628b to
2f271f8
Compare
Contributor
Author
|
0ecb4c2 includes an updated version that doesn't force the round-trip to the driver if no module with the new modes is used. |
Contributor
Author
|
obsolete now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
IEEE 802.15.4g-2012 defines new PHY modes (MR-O-QPSK, MR-OFDM and MR-FSK) with a PDU of 2047 bytes.
Devices like at86rf215 can support both the old mode(s) as well as the new ones, so the IP stack has to be informed about the PDU change when the modulation changes.
I introduced a new
NETOPT_IEEE802154_PHYto get/set the phy mode.For GNRC to use the new MTU,
gnrc_netif_ipv6_init_mtu()has to be called.Now I don't know where this should be called.
Calling it in
gnrc_netif_set_from_netdev()won't work since at this point the command hasn't reached the driver yet and the old PDU would be returned.Another option would be calling it in the driver, but that would mean a layering violation.
Or is there a way to register a callback to be executed after a netif command?
Testing procedure
nothing to test yet
Issues/PRs references
alternative to #12835