sys/shell: add missing stdio include in sc_loramac.c#12968
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Dec 16, 2019
Merged
sys/shell: add missing stdio include in sc_loramac.c#12968benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
aabadie
added
Impact: minor
benpicco
approved these changes
Dec 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes a minor missing stdio.h include in
sc_loramac.c. Since this file uses a lot of puts/printf, it makes sense to add this include here.This PR will also fix a build issues with Hifive1 boards when the SPI support will be merged. See here.
Testing procedure
This command fails without this PR but works with this PR.
Issues/PRs references
Will be required by #12957.