Skip to content

pkg/nimble: bump version and remove obsolete patch#13112

Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:opt_nimble_verjan20removextimerpath
Jan 15, 2020
Merged

pkg/nimble: bump version and remove obsolete patch#13112
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:opt_nimble_verjan20removextimerpath

Conversation

@haukepetersen
Copy link
Contributor

@haukepetersen haukepetersen commented Jan 13, 2020

Contribution description

#9530 added an ugly patch to NimBLE, which causes trouble when working with a local NimBLE source tree... To get rid of it, I patched NimBLE upstream (apache/mynewt-nimble#729).

This PR makes the NimBLE package use the latest master, which contains that fix, so no need for patching anymore.

Testing procedure

Simply verify that e.g. examples/nimble_gatt and tests/nimble_l2cap are still in order.

Issues/PRs references

#9530.

@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Jan 13, 2020
@ghost ghost added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jan 15, 2020
ghost
ghost approved these changes Jan 15, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
Version bump is alright. Fixing this in nimble instead of using a patch is reasonable and seems like the proper way to go here.

@haukepetersen
Copy link
Contributor Author

haukepetersen commented Jan 15, 2020

All green -> go

@SemjonKerner thanks for the quick review!

@haukepetersen haukepetersen merged commit 5d6063b into RIOT-OS:master Jan 15, 2020
@haukepetersen haukepetersen deleted the opt_nimble_verjan20removextimerpath branch January 15, 2020 09:09
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: BLE Area: Bluetooth Low Energy support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

2 participants

@haukepetersen @fjmolinas