boards/slwstk6000b-*: cleanup#13180
Merged
aabadie merged 5 commits intoRIOT-OS:masterfrom Mar 3, 2020
Merged
Conversation
Contributor
|
This PR fails on some efm32 boards. For example on Details |
Contributor
Author
|
I can't reproduce and this PR does not touch that board.
|
Contributor
Author
Contributor
Ah yes, sorry :) |
Contributor
Author
aabadie
reviewed
Feb 28, 2020
Contributor
|
Please rebase |
8f2f62c to
f5ace89
Compare
Contributor
Author
|
@aabadie I rebased as well as removing a commit that was doing already merged changes. I also changed some variable namse |
f5ace89 to
76d2fe1
Compare
aabadie
reviewed
Mar 3, 2020
76d2fe1 to
86ed76f
Compare
aabadie
approved these changes
Mar 3, 2020
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Code is cleaner, no functional change.
ACK
Contributor
|
All green, go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
slwstk6000b-*uses shell calls to resolve some variables like theJLINK_DEVICEand theCPU_MODEL, this can be done more efficiently withMAKEbuiltins.This PR also takes care of addressing the missing
TODO move CPU_MODEL here based on the daughter boardSome exports are removed as well as some MODULES moved.
Testing procedure
master
pr
everything should still works as before so try a couple of applications.
murdock will check build stuff
Issues/PRs references
Relates to #10850
Also relates to #9913
This is a first cleanup step, when #12407 is merged and agreed I will move towards a folder based approach.