Skip to content

xtimer/xtimer.c:_mutex_timeout() improved#13185

Merged
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom
JulianHolzwarth:pr/xtimer_mutex_lock_timeout/first_fix_2
Jan 23, 2020
Merged

xtimer/xtimer.c:_mutex_timeout() improved#13185
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom
JulianHolzwarth:pr/xtimer_mutex_lock_timeout/first_fix_2

Conversation

@JulianHolzwarth
Copy link
Contributor

@JulianHolzwarth JulianHolzwarth commented Jan 22, 2020

Contribution description

This is PR is the same as #11992 because this bug fix was removed on accident.
Was removed in #9530

Testing procedure

same as #11992

Issues/PRs references

#11992

no longer into the "if" when the mutex is free
@JulianHolzwarth
Copy link
Contributor Author

@MichelRottleuthner

@benpicco benpicco requested a review from kaspar030 January 22, 2020 18:09
@benpicco benpicco added Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 22, 2020
Copy link
Contributor

@MichelRottleuthner MichelRottleuthner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with this old commit from #11992 "reverted". Current master crashes, with this PR it works fine again.
ACK.

@MichelRottleuthner
Copy link
Contributor

@fjmolinas I think this one should also be backported.

@MichelRottleuthner MichelRottleuthner merged commit 0950e01 into RIOT-OS:master Jan 23, 2020
@MichelRottleuthner MichelRottleuthner added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 23, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.01 milestone Apr 24, 2020
@JulianHolzwarth JulianHolzwarth deleted the pr/xtimer_mutex_lock_timeout/first_fix_2 branch May 8, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants