makefiles/dependencies_debug.inc.mk: add DEPENDENCY_DEBUG_SORT_VARS#13222
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Jan 28, 2020
Merged
makefiles/dependencies_debug.inc.mk: add DEPENDENCY_DEBUG_SORT_VARS#13222aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie merged 1 commit intoRIOT-OS:masterfrom
Conversation
Define DEPENDENCY_DEBUG_SORT_VARS that can be set as 1 so that DEPS_DEBUG_VARS are sorted before saving to file.
Contributor
Author
|
@cladmi does my interpretation of why you didn't sort by default match your reasoning? |
Contributor
|
@fjmolinas yes I did it to keep the duplication and declaration order as it helped notice when they were changed during a refactoring so ensured the change was reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Define
DEPENDENCY_DEBUG_SORT_VARSthat can be set as 1 so thatDEPS_DEBUG_VARSare sorted before saving to file.I'm not sure why @cladmi only sorted
FEATURES_REQUIREDandFEATURES_PROVIDED. As far what I can tell, sorting hides a lot of debug information on the order the variable was added and by whom. For this reason I leave the option as disabled by default. But being able to set this can reduce the noise significantly when comparing the dependencies for the whole tree, e.g. as was done in #12898.Testing procedure
BOARD=pic32-clicker make dependency-debug -C examples/hello-world/DEPENDENCY_DEBUG_SORT_VARS=1 BOARD=pic32-clicker make dependency-debug -C examples/hello-world/Issues/PRs references