waspmote-pro: don't build the boards_common_atmega module#13230
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jan 30, 2020
Merged
waspmote-pro: don't build the boards_common_atmega module#13230benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
Only include its headers. Without this change board_init would be defined twice. Once in `boards/waspmote-pro/board.c` and the other time `boards/common/atmega/board.c`.
benpicco
added
Area: boards
benpicco
approved these changes
Jan 29, 2020
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Murdock is happy, which again confirms that this was not needed.
Member
Author
|
@benpicco does this need an additional approval or can it be merged as is? |
leandrolanzieri
added
the
Impact: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This was discovered while implementing link time reordering in #13176. Without this change
board_initwould be defined twice. Once inboards/waspmote-pro/board.cand the other time inboards/common/atmega/board.c.Testing procedure
Similar to #13229 either apply #13176 or read the code and verify that
board_initis defined twice for this board.Issues/PRs references