core: turn kernel_init.c and panic.c into submodules of core#13241
core: turn kernel_init.c and panic.c into submodules of core#13241kaspar030 merged 2 commits intoRIOT-OS:masterfrom
Conversation
bootloaders/riotboot/Makefile
Outdated
|
|
||
| # Disable unused modules | ||
| CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE | ||
| DISABLE_MODULE += core_init core_msg |
There was a problem hiding this comment.
What about core_panic, shouldn't it be disabled as well?
There was a problem hiding this comment.
What about
core_panic, shouldn't it be disabled as well?
Yes, that'll be another PR.
There was a problem hiding this comment.
Yes, that'll be another PR.
actually, that doesn't make sense. They both require exactly the same testing.
2408bf4 to
b6703f4
Compare
@nmeum Does this fix the issues with linktime re-ordering? |
Yes, it does seem to fix it, did a few tests locally. I also just pushed your two commits on the #13176 link time reordering branch. Since I can just rebase my branch against master as soon as this PR is merged. If you want, you can wait to see if it passes on the CI. |
haukepetersen
left a comment
There was a problem hiding this comment.
Change makes a lot of sense! Tested with native and arduino-due, everything still behaves as expected.
ACK.
|
Thanks @nmeum @haukepetersen! |
Contribution description
This PR changes the default kernel_init to be a submodule called "core_init".
That makes it possible to completely bypass it, as done by riotboot.
Previously, riotboot depended on a specific link order to properly override
kernel_init()core_initis made a default module, riotboot simply disables it.Same with
panic.cturned into thecore_panicmodule.Testing procedure
CI can do that.
Issues/PRs references
#13238