driver/at86rf2xx use luid_get_eui64 to genenerate EUI#13273
Closed
kfessel wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
driver/at86rf2xx use luid_get_eui64 to genenerate EUI#13273kfessel wants to merge 1 commit intoRIOT-OS:masterfrom
kfessel wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
I can't test this. |
using luid_get_eui64 ensures: - local admin address bit set was done manually before - group address bit unset was done manually before - count eui up was missing (luid_get counts up byte 0, the bit changes above make LSB and LSB<<1 of byte 0 constant -> 4 addresses are the same)
3775842 to
3de6520
Compare
Contributor
Author
|
typo fixed |
Member
|
This seem reasonable, however, there are other PRs like this flying around: #12600 |
Contributor
Author
Member
Member
|
Apparently, this was already fixed as side effect by #13362, which was merged to solve the issue with the collisions of the short addresses in INRIAs testbed. |
Member
|
Then can this be closed? |
Member
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using luid_get_eui64 ensures:
was done manually before
was done manually before
was missing
(luid_get counts up byte 0, the bit changes above make
LSB and LSB<<1 of byte 0 constant -> 4 addresses are the same)
multiple devices will get the same eui
(since the same luid generation is used in in different drivers
it might happen even though different devices are used)