Skip to content

tests/event_threads: remove arch_arm7 from blacklist#13317

Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco:arm7-event_thread
Feb 26, 2020
Merged

tests/event_threads: remove arch_arm7 from blacklist#13317
benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco:arm7-event_thread

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 7, 2020 •
edited
Loading

Contribution description

To be used for array dimensions, ISR_STACKSIZE must be a constant at compile time.
We can't rely on the linker to fill it in later through information from the linker script.
The duplication of information is unfortunate, but I suppose everyone else is doing it.

Testing procedure

tests/event_threads should compile (and run) on msba2.

Issues/PRs references

introduced by #12474
touches #4693

@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: cpu Area: CPU/MCU ports labels Feb 7, 2020
@benpicco benpicco requested review from kaspar030 and maribu February 7, 2020 12:53
maribu
maribu reviewed Feb 7, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

maribu
maribu reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@benpicco
cpu/lpc2387: don't define interrupt stack size in linkerscript
ceee5b1 
Define the interrupt stacks in C code like it is done for Cortex-M.
@benpicco
tests/event_threads: remove arch_arm7 from blacklist
6666e1d 
Now that ISR_STACKSIZE is hard-coded, there is no reason to blacklist
the architecture anymre.
maribu
maribu reviewed Feb 24, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise. I currently don't have the time to test this during my parental leave. Maybe @fabian18 give this a spin using one of the MSB-A2 boards in my office and confirm that it still works?

@fabian18
Copy link
Contributor

fabian18 commented Feb 24, 2020

Ok, I will test it tomorrow.

@fabian18
Copy link
Contributor

fabian18 commented Feb 25, 2020

Tested on msba2, works fine.

2020-02-25 09:18:23,148 # Help: Press s to start test, r to print it is ready
s
2020-02-25 09:18:27,904 # START
2020-02-25 09:18:27,926 # main(): This is RIOT! (Version: 2020.04-devel-320-g6666e1-arm7-event_thread)
2020-02-25 09:18:27,926 # medium
2020-02-25 09:18:27,926 # high
2020-02-25 09:18:27,926 # main done
2020-02-25 09:18:27,926 # low

maribu
maribu approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabian18: Thanks for testing!

ACK

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 25, 2020
@benpicco
Copy link
Contributor Author

benpicco commented Feb 25, 2020

@maribu thank you, enjoy your time off ☺️

@benpicco benpicco merged commit 99f3f67 into RIOT-OS:master Feb 26, 2020
@benpicco benpicco deleted the arm7-event_thread branch February 26, 2020 07:39
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

4 participants

@benpicco @fabian18 @maribu @leandrolanzieri