drivers/ina2xx: Fixed missing i2c_acquire/release#13324
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Feb 11, 2020
Merged
drivers/ina2xx: Fixed missing i2c_acquire/release#13324benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
Member
Author
|
Output of the test on the MSB-A2 now is: (No load connected, the ADC pins are floating; so the measurements are garbage.) |
Member
Author
|
@fjmolinas: This should be backported to the release, right? |
benpicco
approved these changes
Feb 10, 2020
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Code looks good and except for the init function, this does not generate multiple acquire()/release() pairs in a single function.
The added error handling is a nice touch too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
i2c_acquire()andi2c_release()Testing procedure
tests/driver_ina2xxshould now work on all boardsIssues/PRs references
Found while testing #13037