Skip to content

Makefile.dep: deduplicate DEFAULT_MODULE#13363

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:Makefile.dep-dedup
Feb 13, 2020
Merged

Makefile.dep: deduplicate DEFAULT_MODULE#13363
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:Makefile.dep-dedup

Conversation

@benpicco
Copy link
Contributor

Contribution description

I think those were added twice by accident.
This cleans that up.

Testing procedure

One occurence of the keyword should be enough, so no change is expected.
Or maybe I'm missing something and they were there twice deliberately?

Issues/PRs references

introduced by #13089

I think those were added twice by accident.
This cleans that up.

introduced by RIOT-OS#13089
@benpicco benpicco added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Feb 13, 2020
@benpicco benpicco requested a review from fjmolinas February 13, 2020 10:47
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030
Copy link
Contributor

Thanks @benpicco, I'd notice one duplicate entry but didn't get to open a PR...

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 13, 2020
@benpicco benpicco merged commit 8a091af into RIOT-OS:master Feb 13, 2020
@benpicco benpicco deleted the Makefile.dep-dedup branch February 13, 2020 15:52
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants