vera++: remove non-zero exit code

[jia200x]

Contribution description

As pointed out in #13400 (comment), Vera++ is producing several errors for existing code.

In order to ease the migration, I propose to move remove the non-zero exit code for Vera++, fix all issues found by Vera++ (similar to #12558) and then re enable it back.

This PR basically tells Vera++ to always exit with error code 0. Errors and warning are still displayed in Travis.

Testing procedure

Issues/PRs references

#12558

[smlng]

or as alternative agree on #13400

[benpicco]

It's not just the long lines though.
Vera also likes to complain about constructs like

    uint32_t reg = OSCCTRL_DFLLCTRLB_QLDIS
#ifdef OSCCTRL_DFLLCTRLB_WAITLOCK
          | OSCCTRL_DFLLCTRLB_WAITLOCK
#endif
    ;

And there is quite some churn for PRs that touch many files, like #13409

[benpicco]

given how many PRs are affected by this, I'd vote for it until we come up with a policy on how to handle those issues.

[miri64]

Our usual way to handle new check tools, so I agree with @benpicco

[benpicco]

Looks like Vera is back already…

[miri64]

Could you name a specific PR, please? Not sure which PR you are referring to. All PRs I've checked had either a pass by vera++ (a green tick after the script... it still shows some errors though) or timed out static tests (see #13426).

[miri64]

If you are referring to #13411 and #13414, both were build on Travis before this PR was merged, so no wonder ;-). A simple rebuild would have helped (which as a maintainer you should be able to do with a simple login at Travis)...