Skip to content

net/gcoap: fix vera++ warnings#13454

Merged
kb2ma merged 2 commits intoRIOT-OS:masterfrom
kb2ma:gcoap/fix_vera_warnings
Feb 24, 2020
Merged

net/gcoap: fix vera++ warnings#13454
kb2ma merged 2 commits intoRIOT-OS:masterfrom
kb2ma:gcoap/fix_vera_warnings

Conversation

@kb2ma
Copy link
Member

@kb2ma kb2ma commented Feb 24, 2020

Contribution description

During development of #13386, @miri64 and I noticed a couple of warnings now generated for gcoap.c by the vera++ check in the CI. This PR fixes those up, and also updates my copyright notice.

sys/net/application_layer/gcoap/gcoap.c:106: warning: too many consecutive empty lines
sys/net/application_layer/gcoap/gcoap.c:438: warning: full block {} expected in the control structure

This PR does not address line length warnings.

Testing procedure

Verify the CI build no longer reports the warnings.

Issues/PRs references

N/A

@kb2ma kb2ma added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: CoAP Area: Constrained Application Protocol implementations labels Feb 24, 2020
@kb2ma kb2ma added this to the Release 2020.04 milestone Feb 24, 2020
@kb2ma kb2ma requested review from miri64 and smlng February 24, 2020 11:34
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Breaking changes should be discovered by Murdock ;-)

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 24, 2020
@kaspar030 kaspar030 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 24, 2020
@kaspar030
Copy link
Contributor

#13456

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 24, 2020
@kb2ma kb2ma merged commit a2c5ec7 into RIOT-OS:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants