cpu/stm32_common/periph: Fix multicast filtering#13487
Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom Feb 26, 2020
Merged
cpu/stm32_common/periph: Fix multicast filtering#13487PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
Area: drivers
Contributor
|
Fixes the issue of not working IPv6: (Neighbor Discovery Protocol) needs Ethernet Group (Muticast) addresses to work. (maybe this could be part of the commit message) i testes the patch: compile -> flash -> (device reset (there is an issue) -> ping is working again could someone please bump murdock for #13470 : I would like to see debugging work again on master |
benpicco
added
Reviewed: 3-testing
Member
|
I've tested this with Linux<->RIOT on a nucleo-f767z1 running examples/gcoap. In more detail:
I'm still not happy to enable all multicast traffic by default. @JannesVolkens as discussed offline, please open an issue for that |
PeterKietzmann
approved these changes
Feb 26, 2020
Contributor
|
created Issue #13490 to track the nucleo board needs a reset bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
After #13383 fixed the eth unicast filtering on stm32 , there were problems (described in #13383 ) when using IP. This PR is a fix for this problem by reactivating the passing of all frames with a multicast address.
Testing procedure
None.
Issues/PRs references
#13383