tests: handle cml interactive_sync disabling#13512
Merged
dylad merged 1 commit intoRIOT-OS:masterfrom Mar 2, 2020
Merged
Conversation
Contributor
|
Hm why not do #ifdef MODULE_TEST_UTILS_INTERACTIVE_SYNC
void test_utils_interactive_sync(void);
#else
static inline void test_utils_interactive_sync(void) {}
#endifin |
If the header file is included test_utils_interactive_sync() will be defined as an empty function when the module is not used, e.g. added to DISABLE_MODULES in tests/*
5fe8663 to
091ab15
Compare
Contributor
Author
Done. |
dylad
approved these changes
Mar 2, 2020
Member
dylad
left a comment
There was a problem hiding this comment.
Tested with the given procedure. Work as expected.
Thanks @fjmolinas, my debugging sessions will be smoother !
Member
|
Here we go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If not running the automatic tests then having to enter
son every test can be annoying. This can be easily disable by usingDISABLE_MODULE+=test_utils_interactive_syncbut this does not work for tests that need to include it directly in the application, add header guards for this.Testing procedure
BOARD=pba-d-01-kw2x make -C tests/ps_schedstatistics/ flash termDISABLE_MODULE+=test_utils_interactive_sync BOARD=pba-d-01-kw2x make -C tests/ps_schedstatistics/ flash termIn master this would fail since there would be some undefined references.
Issues reference
The is the remaining case of
tests/periph_rtcthat will be dealt with by #13511