Skip to content

gnrc_rpl: add default value to GNRC_RPL_DEFAULT_NETIF#13628

Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
jia200x:pr/gnrc_rpl_macro
Mar 13, 2020
Merged

gnrc_rpl: add default value to GNRC_RPL_DEFAULT_NETIF#13628
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
jia200x:pr/gnrc_rpl_macro

Conversation

@jia200x
Copy link
Member

@jia200x jia200x commented Mar 12, 2020

Contribution description

See #13226 (comment)

Testing procedure

Test with gnrc_networking. Check that RPL still compile and works as expected.
Then, try manually setting the GNRC_RPL_DEFAULT_NETIF to the ieee802.15.4 interface and check that everything works

Issues/PRs references

#13226

@jia200x jia200x mentioned this pull request Mar 12, 2020
Merged
@benpicco benpicco added Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Mar 12, 2020
@jia200x jia200x force-pushed the pr/gnrc_rpl_macro branch from 04e24d5 to b553535 Compare March 13, 2020 12:30
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 13, 2020
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 13, 2020
leandrolanzieri
leandrolanzieri approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without setting GNRC_RPL_DEFAULT_NETIF, and with 1 and 2 interfaces. Logic works properly. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Mar 13, 2020
@leandrolanzieri leandrolanzieri merged commit d281d48 into RIOT-OS:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

3 participants

@jia200x @leandrolanzieri @benpicco