Skip to content

cpu/esp8266: add RTT based RTC#13670

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp8266/add_rtt_based_rtc
Mar 21, 2020
Merged

cpu/esp8266: add RTT based RTC#13670
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp8266/add_rtt_based_rtc

Conversation

@gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Mar 20, 2020

Contribution description

This PR removes the dummy periph_rtc module and enables the use of RTT based RTC implementation as provided by PR #13519 .

Testing procedure

Run tests/periph_rtc on any ESP8266 board.

Issues/PRs references

Uses PR #13519.

@gschorcht gschorcht requested a review from MrKevinWeiss as a code owner March 20, 2020 13:33
@gschorcht gschorcht requested a review from benpicco March 20, 2020 13:33
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Mar 20, 2020
@benpicco
Copy link
Contributor

benpicco commented Mar 20, 2020

Since you already have FEATURES_PROVIDED += periph_rtt in Makefile.features you can also add FEATURES_PROVIDED += periph_rtc now.

@gschorcht
Copy link
Contributor Author

gschorcht commented Mar 20, 2020

Since you already have FEATURES_PROVIDED += periph_rtt in Makefile.features you can also add FEATURES_PROVIDED += periph_rtc now.

Ok.

benpicco
benpicco approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash.

@gschorcht
cpu/esp8266: add RTT based RTC
b7781c7 
fixup! cpu/esp8266: add RTT based RTC
@gschorcht gschorcht force-pushed the cpu/esp8266/add_rtt_based_rtc branch from 66e331c to b7781c7 Compare March 21, 2020 07:50
@benpicco benpicco merged commit 5aff374 into RIOT-OS:master Mar 21, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 26, 2020
@gschorcht gschorcht deleted the cpu/esp8266/add_rtt_based_rtc branch June 25, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

3 participants

@gschorcht @benpicco @leandrolanzieri