Skip to content

bootloaders/riotboot: use stdio_null#13704

Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_riotboot_stdio_null
Mar 25, 2020
Merged

bootloaders/riotboot: use stdio_null#13704
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_riotboot_stdio_null

Conversation

@fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Mar 24, 2020

Contribution description

Instead of disablin stdio_ modules force stdio_null to be used just as tests/minimal

Testing procedure

  • green murdock

  • tests/riotboot should still work

BOARD=usb-kw41z make -C tests/riotboot flash test

Current slot=0
> curslothdr
 curslothdr
Image magic_number: 0x544f4952
Image Version: 0x5e7a4dc9
Image start address: 0x00001100
Header chksum: 0xd20e5ae5

> getslotaddr 0
 getslotaddr 0
Slot 0 address=0x00001100
> dumpaddrs
 dumpaddrs
slot 0: metadata: 0x1000 image: 0x00001100
slot 1: metadata: 0x40800 image: 0x00040900
> TEST PASSED

Issues/PRs references

Expands on #13674.

@fjmolinas fjmolinas added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: OTA Area: Over-the-air updates labels Mar 24, 2020
benpicco
benpicco reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also makes riotboot a good bit smaller, which is nice.

@fjmolinas
Copy link
Contributor Author

fjmolinas commented Mar 25, 2020

maybe @kaspar030 should take a look at this one as well?

@benpicco benpicco requested a review from kaspar030 March 25, 2020 07:39
@fjmolinas
Copy link
Contributor Author

fjmolinas commented Mar 25, 2020

Offline @kaspar030 agreed this change makes sense as well. So lets go!

@fjmolinas fjmolinas merged commit ad0abd3 into RIOT-OS:master Mar 25, 2020
@fjmolinas fjmolinas deleted the pr_riotboot_stdio_null branch March 25, 2020 10:08
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 26, 2020
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: OTA Area: Over-the-air updates CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

3 participants

@fjmolinas @benpicco @leandrolanzieri