Skip to content

examples/gnrc_border_router: add sock_dns as a comment#13735

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
miri64:example/enh/sock_dns-comment
Mar 27, 2020
Merged

examples/gnrc_border_router: add sock_dns as a comment#13735
benpicco merged 1 commit intoRIOT-OS:masterfrom
miri64:example/enh/sock_dns-comment

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Mar 27, 2020

Contribution description

Less feature-creepy alternative to #13732

Testing procedure

Uncomment the given line and compile. When the upstream router advertisement daemon is configured to send RDNSS options, DNS requests will be send to that server if e.g.

ping6 google.com

is typed.

Issues/PRs references

Alternative to #13732

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: examples Area: Example Applications labels Mar 27, 2020
@miri64 miri64 added this to the Release 2020.04 milestone Mar 27, 2020
@miri64 miri64 requested a review from benpicco March 27, 2020 10:01
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 27, 2020
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Mar 27, 2020
@miri64
Copy link
Member Author

miri64 commented Mar 27, 2020

Only adds a comment so no need to bother Murdock with it too much ;-).

@benpicco benpicco merged commit 4753679 into RIOT-OS:master Mar 27, 2020
@miri64 miri64 deleted the example/enh/sock_dns-comment branch March 27, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: examples Area: Example Applications Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants