shell/gnrc_icmpv6_echo: fix incorrect use of gnrc_netif_highlander()#13737
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Mar 27, 2020
Merged
shell/gnrc_icmpv6_echo: fix incorrect use of gnrc_netif_highlander()#13737miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
Type: bug
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
benpicco
force-pushed
the
highlander-fix
branch
from
05ce352 to
f247d74
Compare
Contributor
Author
|
Following #13736 (comment) I dropped all but the |
benpicco
changed the title
miri64
reviewed
Mar 27, 2020
miri64
approved these changes
Mar 27, 2020
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
With my suggested fix it works as expected. Please address and squash so we can get this merged ASAP.
Member
|
Please also fix commit message and PR title for something more in line with the current change. |
benpicco
force-pushed
the
highlander-fix
branch
2 times, most recently
from
ed2f370 to
158ca59
Compare
Contributor
Author
shell/gnrc_icmpv6_echo: |
We want to check if there *is* only one interface, not if there *can* be no more than one interface here.
miri64
approved these changes
Mar 27, 2020
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Re-ACK. Tested the current state with and without GNRC_NETIF_SINGLE defined. Please squash.
miri64
added
the
CI: ready for build
benpicco
force-pushed
the
highlander-fix
branch
from
158ca59 to
e1ce24a
Compare
leandrolanzieri
added
the
Impact: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
There are instances where
gnrc_netif_highlander()is used to check if there is only one interface.The
gnrc_netif_highlander()however only returns true if there can only be one interface.It will return
falseif there is only one interface, but more could be configured.Testing procedure
see #12994 (comment)
Issues/PRs references
alternative to #13736