Skip to content

nanocoap: add convenience function for adding path elements#13805

Merged
kb2ma merged 2 commits intoRIOT-OS:masterfrom
benpicco:nanocoap_path
Apr 4, 2020
Merged

nanocoap: add convenience function for adding path elements#13805
kb2ma merged 2 commits intoRIOT-OS:masterfrom
benpicco:nanocoap_path

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Apr 3, 2020

Contribution description

Add a convenience function to make adding additional sub-path options easier.

The user might not want to construct the entire path at once (it will be split up internally anyway), e.g. when adding additional resource options.

Testing procedure

Nothing to test

Issues/PRs references

@benpicco benpicco added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: CoAP Area: Constrained Application Protocol implementations labels Apr 3, 2020
@benpicco benpicco requested review from bergzand and kb2ma April 3, 2020 13:52
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 3, 2020
Copy link
Member

@kb2ma kb2ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the useful addition, @benpicco. See inline comments.

@kb2ma
Copy link
Member

kb2ma commented Apr 4, 2020

Looks good, please squash.

benpicco added 2 commits April 4, 2020 17:06
Add a convenience function to make adding additional sub-path
options easier.
@kb2ma kb2ma added this to the Release 2020.04 milestone Apr 4, 2020
@kb2ma kb2ma added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 4, 2020
@kb2ma
Copy link
Member

kb2ma commented Apr 4, 2020

Looks like a spurious failure; re-kicked Murdock.

@benpicco
Copy link
Contributor Author

benpicco commented Apr 4, 2020

Should be fixed by #13814

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 4, 2020
@kb2ma kb2ma merged commit 127f8ca into RIOT-OS:master Apr 4, 2020
@benpicco benpicco deleted the nanocoap_path branch April 4, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants