Skip to content

tests: fix for GNRC_NETIF_SINGLE#13835

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:tests/fix/gnrc_netif_single
Apr 8, 2020
Merged

tests: fix for GNRC_NETIF_SINGLE#13835
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:tests/fix/gnrc_netif_single

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Apr 8, 2020

Contribution description

Some of the tests requiring sudo do not work anymore since #12994. This fixes them.

Testing procedure

All of these tests should now pass (with sudo):

tests/emcute
tests/gnrc_dhcpv6_client
tests/gnrc_dhcpv6_client_6lbr
tests/gnrc_ipv6_ext
tests/gnrc_ipv6_ext_frag
tests/gnrc_sock_dns
tests/gnrc_tcp

tests/gnrc_rpl_srh seems to have a problem with its sniffer, which I am currently investigating.

Issues/PRs references

Follow-up on #12994.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: tests Area: tests and testing framework labels Apr 8, 2020
@miri64 miri64 requested a review from leandrolanzieri April 8, 2020 09:14
@miri64 miri64 added this to the Release 2020.04 milestone Apr 8, 2020
@leandrolanzieri
Copy link
Contributor

leandrolanzieri commented Apr 8, 2020

Thanks for the fixes. I'm testing this right away.

leandrolanzieri
leandrolanzieri approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the broken tests. ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 8, 2020
@miri64 miri64 merged commit 6ef0bf9 into RIOT-OS:master Apr 8, 2020
@miri64 miri64 deleted the tests/fix/gnrc_netif_single branch April 8, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: network Area: Networking Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @leandrolanzieri