Skip to content

drivers/edbg_eui: add driver to get MAC address from Atmel EDBG#14134

Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom
benpicco:drivers/edbg_eui
May 26, 2020
Merged

drivers/edbg_eui: add driver to get MAC address from Atmel EDBG#14134
bergzand merged 1 commit intoRIOT-OS:masterfrom
benpicco:drivers/edbg_eui

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented May 25, 2020

Contribution description

The EDBG debugger on the samr21-xpro contains a unique 64 bit address intended to be used as a MAC address for the internal radio.

This adds a driver to read that EUI-64 from the debugger, it should match with the MAC address printed on the label on the board.

Testing procedure

Run tests/driver_edbg_eui

2020-05-25 12:39:28,297 # main(): This is RIOT! (Version: 2020.07-devel-727-gee319a-drivers/edbg_eui)
2020-05-25 12:39:28,302 # EUI-64: 00 04 25 19 18 01 c8 c5
2020-05-25 12:39:28,303 # [SUCCESS]

The address should match the one printed on the board.

Issues/PRs references

split out of #12641

@benpicco benpicco added Area: drivers Area: Device drivers Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 25, 2020
bergzand
bergzand reviewed May 26, 2020
View reviewed changes
@bergzand bergzand added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label May 26, 2020
@bergzand
Copy link
Member

bergzand commented May 26, 2020

Tested, matches the printed address somewhat:
image

2020-05-26 10:01:11,182 # main(): This is RIOT! (Version: 2020.07-devel-728-gd657fe-HEAD)
2020-05-26 10:01:11,187 # EUI-64: 00 04 25 19 18 01 bd 01
2020-05-26 10:01:11,188 # [SUCCESS]

bergzand
bergzand reviewed May 26, 2020
View reviewed changes
@bergzand bergzand self-assigned this May 26, 2020
@benpicco
drivers/edbg_eui: add driver to get MAC address from Atmel EDBG
616ebf9 
The EDBG debugger on the `samr21-xpro` contains a unique 64 bit address
intended to be used as a MAC address for the internal radio.

This adds a driver to read that EUI-64 from the debugger, it should match
with the MAC address printed on the label on the board.
@benpicco benpicco force-pushed the drivers/edbg_eui branch from d657fef to 616ebf9 Compare May 26, 2020 08:44
bergzand
bergzand approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@bergzand bergzand merged commit b44b820 into RIOT-OS:master May 26, 2020
@benpicco benpicco deleted the drivers/edbg_eui branch May 26, 2020 09:50
@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergzand bergzand bergzand approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@bergzand bergzand

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@benpicco @bergzand @miri64