Skip to content

riotctrl_shell: remove unneeded variables and imports#14437

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
miri64:tools/cleanup/unused-vars-and-imports
Jul 4, 2020
Merged

riotctrl_shell: remove unneeded variables and imports#14437
aabadie merged 1 commit intoRIOT-OS:masterfrom
miri64:tools/cleanup/unused-vars-and-imports

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Jul 4, 2020

Contribution description

This slipped through the review in #11406.

Testing procedure

Tests still pass:

cd dist/pythonlibs/riotctrl_shell/; tox

Issues/PRs references

Follow-up on #11406.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 4, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 4, 2020
@miri64 miri64 requested a review from aabadie July 4, 2020 10:22
benpicco
benpicco approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger is unused.

@aabadie aabadie merged commit 93c5084 into RIOT-OS:master Jul 4, 2020
@miri64 miri64 deleted the tools/cleanup/unused-vars-and-imports branch July 17, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees

No one assigned

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @benpicco @aabadie