riotctrl_shell.netif: add missing check_term decorator#14460
Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom Jul 9, 2020
Merged
riotctrl_shell.netif: add missing check_term decorator#14460aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie merged 2 commits intoRIOT-OS:masterfrom
Conversation
miri64
added
Type: bug
Contributor
|
Is there a way to check from a test that the decorator is correctly set ? Here there's a fix but no regression test is provided. |
`check_term` calls `run_term` of the `ctrl` if necessary.
Member
Author
I've adapted the |
aabadie
approved these changes
Jul 9, 2020
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Looks good and the CI checks are green. I trust your local tests about the non regression test (thanks for providing it btw).
ACK.
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
In #14441 I forgot to add the
check_term()decorators to the methods that require it, which if not added one might run into a AttributeError since thetermmember ofself.riotctrlis still None. This fixes that.Testing procedure
tests-toolsGithub Action should still pass.Issues/PRs references
Follow-up on #14441.