riotctrl_shell.gnrc: move compile object init to parser constructors#14462
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Jul 9, 2020
Merged
Conversation
miri64
added
Type: enhancement
miri64
added
CI: ready for build
miri64
force-pushed
the
riotctrl_shell.gnrc/enh/compile-to-init
branch
from
9ce9192 to
c3e6d89
Compare
Member
Author
|
Rebased and adapted for current master |
aabadie
approved these changes
Jul 9, 2020
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Good improvement and all checks are green.
ACK and go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This way they are not initialized everytime the
parse()method is called but only once at initialization of the parser.Testing procedure
tools-testshall passIssues/PRs references
Follow-up on #11406.