Skip to content

examples/micropython: fix checked PID [backport 2020.07]#14530

Merged
aabadie merged 1 commit intoRIOT-OS:2020.07-branchfrom
miri64:backport/2020.07/examples/fix/micropython-14224
Jul 16, 2020
Merged

examples/micropython: fix checked PID [backport 2020.07]#14530
aabadie merged 1 commit intoRIOT-OS:2020.07-branchfrom
miri64:backport/2020.07/examples/fix/micropython-14224

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Jul 15, 2020

Backport of #14518

Contribution description

With #14224 the idle thread became optional, so the main thread can have either 1 or 2 as PID, depending if the idle thread is included or not. As this might also change in the future, it is probably the best to just expect any number.

Testing procedure

make -C examples/micropython flash test

Should now succeed again on e.g. Cortex-M platforms.

Issues/PRs references

Follow-up on #14224

@miri64 miri64 added Area: examples Area: Example Applications Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jul 15, 2020
@miri64 miri64 requested a review from aabadie July 15, 2020 19:52
aabadie
aabadie previously approved these changes Jul 15, 2020
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes, ACK!

With RIOT-OS#14224 the idle thread became
optional, so the main thread can have either 1 or 2 as PID, depending
if the idle thread is included or not. As this might also change in the
future, it is probably the best to just expect any number.

(cherry picked from commit 5599b06)
@miri64
Copy link
Member Author

miri64 commented Jul 15, 2020

Rebased to current release branch (with a little hick-up because I rebased to master by habbit...) needs a new ACK.

@miri64 miri64 force-pushed the backport/2020.07/examples/fix/micropython-14224 branch from f0ba824 to 649f461 Compare July 15, 2020 22:43
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, same changes.

@aabadie aabadie merged commit 16cbf85 into RIOT-OS:2020.07-branch Jul 16, 2020
@miri64 miri64 deleted the backport/2020.07/examples/fix/micropython-14224 branch July 16, 2020 07:23
@miri64 miri64 added this to the Release 2020.07 milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: examples Area: Example Applications Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants