makefiles/info-global.inc.mk: add initial default modules inclusion#15022
makefiles/info-global.inc.mk: add initial default modules inclusion#15022aabadie merged 1 commit intoRIOT-OS:masterfrom
Conversation
|
I forgot how slow |
|
@maribu do you have some results to share ? (or did you gave up with the script ? :) ) |
No. I decided after 30 minutes that this is something my notebook should do over night, when I'm not trying to also use it for working. Maybe it is time to buy a new one... |
|
I ran the script 😎 and there are differences. Here a partial output of the diff The master commit corresponds to the commit just before this PR. |
|
What is first in the diff master or pr? |
|
@aabadie I believe the differences are to be expected since before the default modules where not added, and now they are so we can of course them now. |
aabadie
left a comment
There was a problem hiding this comment.
After some off-line discussion with @fjmolinas, we came up to the conclusion that this PR is good to merge.
The analysis of the dependencies check script shows that no module are removed and make info-board-supported is based on the same dependencies as the ones generated by the regular build system.
ACK!
|
Thanks for the review! |
Contribution description
In #14132 the cache mechanism was removed, but
defaultmodules initial inclusionshould still be present to mimic
Makefile.includeunless I'm missing soemthing.I think none of the initially included
defaultmodules has an impact on dependencies sosave_all_dependenciesshould be the same.Testing procedure
./dist/tools/buildsystem_sanity_ check/save_all_dependencies_resolution_variables.sh, but if its not the same it would mean that something in$(RIOTMAKE)/defaultmodules.inc.mkis triggering some dependency.Issues/PRs references