tests/periph_timer_periodic: Use fmt for in-irq printing#15061
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Sep 23, 2020
Merged
tests/periph_timer_periodic: Use fmt for in-irq printing#15061kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
bergzand
added
Area: tests
kaspar030
reviewed
Sep 22, 2020
This replaces the printf statement in the timer callback with fmt-based printing and a single puts. This is less heavy on the stack usage than printf, making this test a bit easier to digest on the smaller platforms.
bergzand
force-pushed
the
pr/tests_timer_periodic/use_fmt
branch
from
5fdb1dc to
57f2bd9
Compare
kaspar030
approved these changes
Sep 23, 2020
Contributor
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
ACK. one less printf in ISR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This replaces the printf statement in the timer callback with fmt-based
printing and a single puts. This is less heavy on the stack usage than
printf, making this test a bit easier to digest on the smaller
platforms.
Flash size increases by almost 200 bytes on the samr21-xpro with LLVM because of the added fmt module.
Testing procedure
The printed test output should remain the same.
Issues/PRs references
reduces the stack size enough to let #14557 pass this test with LLVM on the samr21-xpro 😄