Skip to content

drivers/kw41zrf: register with netdev#15188

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:drivers/kw41zrf-register
Oct 31, 2020
Merged

drivers/kw41zrf: register with netdev#15188
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:drivers/kw41zrf-register

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 8, 2020

Contribution description

Register kw41zrf with netdev so we don't have to generate a EUI inside the driver but can make use of an EUI provider if available.

Testing procedure

Issues/PRs references

alternative to #14363

@benpicco benpicco requested review from benemorius and maribu October 8, 2020 13:54
@benpicco benpicco added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Oct 8, 2020
maribu
maribu reviewed Oct 8, 2020
View reviewed changes
@benpicco benpicco force-pushed the drivers/kw41zrf-register branch from 47106f5 to b32bc3d Compare October 8, 2020 14:19
@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Oct 8, 2020
@maribu
Copy link
Member

maribu commented Oct 8, 2020

@benemorius: Care to test this?

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 11, 2020
@benpicco
Copy link
Contributor Author

benpicco commented Oct 24, 2020

I tested on the openlabs-kw41z-mini:

master

2020-10-24 22:02:26,798 # Iface  6  HWaddr: 65:11  Channel: 26  Page: 0  NID: 0x23 
2020-10-24 22:02:26,802 #           Long HWaddr: 33:E8:95:F6:A0:4F:5C:DA 
2020-10-24 22:02:26,808 #            TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4 
2020-10-24 22:02:26,813 #           ACK_REQ  CSMA  L2-PDU:102  MTU:1280  HL:64  RTR  
2020-10-24 22:02:26,816 #           6LO  IPHC  
2020-10-24 22:02:26,819 #           Source address length: 8
2020-10-24 22:02:26,822 #           Link type: wireless
2020-10-24 22:02:26,827 #           inet6 addr: fe80::31e8:95f6:a04f:5cda  scope: link  VAL
2020-10-24 22:02:26,830 #           inet6 group: ff02::2
2020-10-24 22:02:26,833 #           inet6 group: ff02::1
2020-10-24 22:02:26,836 #           inet6 group: ff02::1:ff4f:5cda
2020-10-24 22:02:26,838 #           
2020-10-24 22:02:26,841 #           Statistics for Layer 2
2020-10-24 22:02:26,843 #             RX packets 0  bytes 0
2020-10-24 22:02:26,847 #             TX packets 2 (Multicast: 2)  bytes 86
2020-10-24 22:02:26,849 #             TX succeeded 2 errors 0
2020-10-24 22:02:26,852 #           Statistics for IPv6
2020-10-24 22:02:26,855 #             RX packets 0  bytes 0
2020-10-24 22:02:26,860 #             TX packets 2 (Multicast: 2)  bytes 128
2020-10-24 22:02:26,865 #             TX succeeded 2 errors 0

this patch

2020-10-24 22:03:16,949 # Iface  6  HWaddr: 6E:32  Channel: 26  Page: 0  NID: 0x23 
2020-10-24 22:03:16,953 #           Long HWaddr: 32:EE:95:F6:A0:4F:5C:DA 
2020-10-24 22:03:16,959 #            TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4 
2020-10-24 22:03:16,965 #           ACK_REQ  CSMA  L2-PDU:102  MTU:1280  HL:64  RTR  
2020-10-24 22:03:16,967 #           6LO  IPHC  
2020-10-24 22:03:16,970 #           Source address length: 8
2020-10-24 22:03:16,973 #           Link type: wireless
2020-10-24 22:03:16,978 #           inet6 addr: fe80::30ee:95f6:a04f:5cda  scope: link  VAL
2020-10-24 22:03:16,985 #           inet6 group: ff02::2
2020-10-24 22:03:16,986 #           inet6 group: ff02::1
2020-10-24 22:03:16,987 #           inet6 group: ff02::1:ff4f:5cda
2020-10-24 22:03:16,989 #           
2020-10-24 22:03:16,992 #           Statistics for Layer 2
2020-10-24 22:03:16,995 #             RX packets 0  bytes 0
2020-10-24 22:03:16,998 #             TX packets 2 (Multicast: 2)  bytes 86
2020-10-24 22:03:17,000 #             TX succeeded 2 errors 0
2020-10-24 22:03:17,003 #           Statistics for IPv6
2020-10-24 22:03:17,006 #             RX packets 0  bytes 0
2020-10-24 22:03:17,011 #             TX packets 2 (Multicast: 2)  bytes 128
2020-10-24 22:03:17,015 #             TX succeeded 2 errors 0
2020-10-24 22:03:17,016 # 
> ifconfig 6 set state reset
2020-10-24 22:04:12,825 #  ifconfig 6 set state reset
2020-10-24 22:04:12,830 # success: set state of interface 6 to RESET
> ifconfig
2020-10-24 22:04:14,911 #  ifconfig
2020-10-24 22:04:14,917 # Iface  6  HWaddr: 6E:32  Channel: 26  Page: 0  NID: 0x23 
2020-10-24 22:04:14,920 #           Long HWaddr: 32:EE:95:F6:A0:4F:5C:DA 
2020-10-24 22:04:14,926 #            TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4 
2020-10-24 22:04:14,932 #           ACK_REQ  CSMA  L2-PDU:102  MTU:1280  HL:64  RTR  
2020-10-24 22:04:14,934 #           6LO  IPHC  
2020-10-24 22:04:14,937 #           Source address length: 2
2020-10-24 22:04:14,940 #           Link type: wireless
2020-10-24 22:04:14,946 #           inet6 addr: fe80::30ee:95f6:a04f:5cda  scope: link  VAL
2020-10-24 22:04:14,948 #           inet6 group: ff02::2
2020-10-24 22:04:14,951 #           inet6 group: ff02::1
2020-10-24 22:04:14,954 #           inet6 group: ff02::1:ff4f:5cda
2020-10-24 22:04:14,956 #           
2020-10-24 22:04:14,959 #           Statistics for Layer 2
2020-10-24 22:04:14,962 #             RX packets 1  bytes 56
2020-10-24 22:04:14,965 #             TX packets 6 (Multicast: 6)  bytes 258
2020-10-24 22:04:14,970 #             TX succeeded 6 errors 0
2020-10-24 22:04:14,971 #           Statistics for IPv6
2020-10-24 22:04:14,975 #             RX packets 0  bytes 0
2020-10-24 22:04:14,979 #             TX packets 6 (Multicast: 6)  bytes 384
2020-10-24 22:04:14,983 #             TX succeeded 6 errors 0

@maribu maribu added Reviewed: 3-testing The PR was tested according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 30, 2020
maribu
maribu approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Test result given in #15188 (comment)

@benpicco benpicco merged commit e77d12d into RIOT-OS:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@benemorius benemorius Awaiting requested review from benemorius

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benpicco @maribu