Skip to content

tests/lwip_sock_tcp: remove duplicated xtimer_init [backport 2020.10]#15191

Merged
fjmolinas merged 1 commit intoRIOT-OS:2020.10-branchfrom
fjmolinas:backport/2020.10/pr_lwip_sock_tcp_xtimer_init
Oct 9, 2020
Merged

tests/lwip_sock_tcp: remove duplicated xtimer_init [backport 2020.10]#15191
fjmolinas merged 1 commit intoRIOT-OS:2020.10-branchfrom
fjmolinas:backport/2020.10/pr_lwip_sock_tcp_xtimer_init

Conversation

@fjmolinas
Copy link
Contributor

Backport of #15189

Contribution description

xtimer is already initiated in auto_init, no need to perform
initiation twice.

Testing procedure

Run tests/lwip_sock_tcp.

Issues/PRs references

Found in #15186

xtimer is already initiated in auto_init, no need to perform
initiation twice.

(cherry picked from commit 7ec1d2e)
@fjmolinas fjmolinas requested a review from miri64 as a code owner October 9, 2020 07:28
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Oct 9, 2020
@fjmolinas fjmolinas requested a review from benpicco October 9, 2020 07:28
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as #15189. ACK.

@leandrolanzieri
Copy link
Contributor

Unrelated error.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 9, 2020
@leandrolanzieri
Copy link
Contributor

Hmm the test result link is not valid anymore. Anyway, compile/tests/ztimer_periodic/native:gnu failed.

@fjmolinas
Copy link
Contributor Author

Unrelated error.

The link is not working for, what error was it?

@fjmolinas fjmolinas merged commit a65b4e1 into RIOT-OS:2020.10-branch Oct 9, 2020
@fjmolinas fjmolinas deleted the backport/2020.10/pr_lwip_sock_tcp_xtimer_init branch October 9, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants