Merged
Conversation
fjmolinas
added
Type: cleanup
fjmolinas
requested review from
DipSwitch,
MrKevinWeiss,
aabadie,
kaspar030 and
vincent-d
as code owners
kaspar030
reviewed
Feb 9, 2021
| #define FLASHPAGE_SIZE (128U) | ||
| #endif | ||
|
|
||
| #if defined(CPU_FAM_STM32L0) || defined(CPU_FAM_STM32L1) || \ |
Contributor
There was a problem hiding this comment.
I think this PR still includes the other commits.
Contributor
Author
There was a problem hiding this comment.
It does. that is why its waiting for the other PR, since it will have a conflict anyway
Contributor
Author
There was a problem hiding this comment.
Ah I understood what you meant, that happened in the original PR, so they are removed now. Thanks for pointing this out.
fjmolinas
force-pushed
the
pr_riotboot_uncrustify
branch
from
9c91ec8 to
6a79d94
Compare
fjmolinas
added
CI: ready for build
Contributor
Author
|
All green here @kaspar030 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While looking at #15912 I realized riotboot files were full of uncrustify issues. To ease reviewing I prefered to split uncrustify changes out and add it to the whitelist.
Testing procedure
Issues/PRs references
Waiting for #15912